This repository was archived by the owner on Nov 6, 2020. It is now read-only.
network-devp2p Fix some clippy errors/warnings#9378
Merged
Conversation
Member
I guess we can safely remove |
ordian
reviewed
Aug 20, 2018
|
|
||
| /// Set the non-reserved peer mode. | ||
| pub fn set_non_reserved_mode(&self, mode: NonReservedPeerMode) { | ||
| pub fn set_non_reserved_mode(&self, mode: &NonReservedPeerMode) { |
77a9bb3 to
ecde3cf
Compare
dvdplm
approved these changes
Aug 21, 2018
ordian
approved these changes
Aug 21, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These errors/warnings are not fixed:
Remarks:
Nodeis not a clone type so I guessshallow copying makes sense